Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5970#discussion_r187589977
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/api/common/typeinfo/TypeInformationTest.java
 ---
    @@ -61,7 +61,7 @@ public void testOfGenericClassForGenericType() {
        @Test
        public void testOfTypeHint() {
                assertEquals(BasicTypeInfo.STRING_TYPE_INFO, 
TypeInformation.of(String.class));
    -           assertEquals(BasicTypeInfo.STRING_TYPE_INFO, 
TypeInformation.of(new TypeHint<String>(){}));
    +           assertEquals(BasicTypeInfo.STRING_TYPE_INFO, Types.STRING);
    --- End diff --
    
    Please undo this one, the test explicitly tests the TypeHint use.


---

Reply via email to