[ 
https://issues.apache.org/jira/browse/FLINK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473821#comment-16473821
 ] 

ASF GitHub Bot commented on FLINK-8989:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5761#discussion_r187847421
  
    --- Diff: 
flink-end-to-end-tests/flink-elasticsearch1-test/src/main/java/org/apache/flink/elasticsearch1/test/Elasticsearch1SinkExample.java
 ---
    @@ -15,10 +15,11 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.streaming.connectors.elasticsearch.examples;
    +package org.apache.flink.elasticsearch1.test;
    --- End diff --
    
    I think the package should be:
    `org.apache.flink.streaming.tests`
    
    This would then be consistent with out other end-to-end test jobs


> End-to-end test: ElasticSearch connector
> ----------------------------------------
>
>                 Key: FLINK-8989
>                 URL: https://issues.apache.org/jira/browse/FLINK-8989
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Major
>
> Similar to FLINK-8988 we should add a end-to-end test which tests the 
> {{ElasticSearch}} connector. We should run against all three supported 
> ElasticSearch versions: 1.x, 2.x and 5.x.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to