[
https://issues.apache.org/jira/browse/FLINK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473819#comment-16473819
]
ASF GitHub Bot commented on FLINK-8989:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5761#discussion_r187847586
--- Diff: flink-end-to-end-tests/flink-elasticsearch2-test/pom.xml ---
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-end-to-end-tests</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.6-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+
+
<artifactId>flink-elasticsearch2-test_${scala.binary.version}</artifactId>
+ <name>flink-elasticsearch2-test</name>
+ <packaging>jar</packaging>
+
+ <!-- Allow users to pass custom connector versions -->
+ <properties>
+ <elasticsearch.version>2.3.5</elasticsearch.version>
--- End diff --
I don't think we need to make this configurable in the tests.
> End-to-end test: ElasticSearch connector
> ----------------------------------------
>
> Key: FLINK-8989
> URL: https://issues.apache.org/jira/browse/FLINK-8989
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Till Rohrmann
> Assignee: mingleizhang
> Priority: Major
>
> Similar to FLINK-8988 we should add a end-to-end test which tests the
> {{ElasticSearch}} connector. We should run against all three supported
> ElasticSearch versions: 1.x, 2.x and 5.x.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)