Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190705206
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -247,7 +249,15 @@ public void shutdown(Time timeout) {
@Override
protected void channelRead0(ChannelHandlerContext ctx, Object
msg) {
- if (msg instanceof FullHttpResponse) {
+ // TODO: should this check for status OK (200) and
treat all other as errors?
--- End diff --
message semantics are handled later when parsing the payload, which
effectively does what you're suggesting. The else branch for debugging; our
rest servers always return `FullHttpResponses`.
---
