Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6071#discussion_r191386855 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java --- @@ -424,6 +480,19 @@ public int setBytes(int index, ScatteringByteChannel in, int length) throws IOEx } } + @Override + public int setBytes(int index, FileChannel in, long position, int length) throws IOException { + // adapted from UnpooledDirectByteBuf: + checkIndex(index, length); + + ByteBuffer tmpBuf = memorySegment.wrap(index, length); + try { + return in.read(tmpBuf); --- End diff -- are you ignoring the `position` argument intentionally?
---