[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492712#comment-16492712
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191147297
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
---
@@ -72,10 +72,19 @@
" leader-election service (like ZooKeeper) is used to
elect and discover the JobManager" +
" leader from potentially multiple standby
JobManagers.");
+ /**
+ * JVM heap size for the JobManager with memory size.
+ */
+ public static final ConfigOption<String> JOB_MANAGER_HEAP_MEMORY =
+ key("jobmanager.heap.size")
+ .defaultValue("1024m")
+ .withDescription("JVM heap size for the JobManager.");
+
/**
* JVM heap size (in megabytes) for the JobManager.
+ * @deprecated use {@link #JOB_MANAGER_HEAP_MEMORY}
*/
- public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY =
+ public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY_MB =
--- End diff --
Missing annotation `@Deprecated`. That way we can remove that option from
docs (which I think we should do).
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
