[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493136#comment-16493136
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
hi @dawidwys thanks for your review suggestion, I have refactored the PR
code except the `MANAGED_MEMORY_SIZE `. The problem you concerned is exists,
the key is suitable for this PR, and it seems we should introduce a new key and
mark this as **@deprecated**, otherwise, We could not avoid user using old
config value without unit.
But it is just a possibility, we can highlight a **Note** message and give
a guidance.
At worst, user config it as **megabytes**, actually it means **bytes""
(`1024 * 1024` difference) , when starting TaskManager, it would cause failed
or show disagreement with Flink web UI. Then use would recheck this
configuration item.
What's your opinion? @StephanEwen
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
