Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193010378
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
 ---
    @@ -40,22 +42,63 @@
     
        private static final Logger LOG = 
LoggerFactory.getLogger(RMQSink.class);
     
    -   protected final String queueName;
    +   private final String queueName;
        private final RMQConnectionConfig rmqConnectionConfig;
        protected transient Connection connection;
        protected transient Channel channel;
        protected SerializationSchema<IN> schema;
    -   private boolean logFailuresOnly = false;
    +   protected boolean logFailuresOnly = false;
    --- End diff --
    
    Is it needed to change the visibility to `protected`?


---

Reply via email to