Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193126219
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
 ---
    @@ -83,7 +103,22 @@ public void throwExceptionIfChannelIsNull() throws 
Exception {
        }
     
        private RMQSink<String> createRMQSink() throws Exception {
    -           RMQSink rmqSink = new RMQSink<String>(rmqConnectionConfig, 
QUEUE_NAME, serializationSchema);
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, QUEUE_NAME, serializationSchema);
    --- End diff --
    
    nit: Java 7 diamond operator should be preferred, i.e., `new RMQSink<>(...)`


---

Reply via email to