Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r195089054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java
---
@@ -31,4 +31,22 @@
* @param <SV> The type of elements in the state
* @param <OUT> The type of the resulting element in the state
*/
-public interface InternalAppendingState<K, N, IN, SV, OUT> extends
InternalKvState<K, N, SV>, AppendingState<IN, OUT> {}
+public interface InternalAppendingState<K, N, IN, SV, OUT> extends
InternalKvState<K, N, SV>, AppendingState<IN, OUT> {
--- End diff --
It almost seems to me that this methods are not truly specific to merging
state and could simply become part of the ``InternalKvState`` interface and the
abstract implementations can also move directly to the respective abstract
classes ``AbstractRocksDBState`` and ``AbstractHeapState``.
---
