Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r195111820
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
@@ -237,4 +249,20 @@ public void addAll(List<V> values) throws Exception {
return keySerializationStream.toByteArray();
}
+
+ @Override
+ public List<V> getInternal() {
+ Iterable<V> list = get();
+ if (list == null) {
+ return null;
+ }
+ List<V> collected = new ArrayList<>();
--- End diff --
We could currently also safe the whole repacking if we change the signature
of `Iterable<V> get()` in this class to return ``List<V>``.
However, I think in the long run it might be worth considering to have this
class be based on `Iterable` instead of `List` because we essentially only use
iterable semantics. @aljoscha what do you think?
---
