Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/979#discussion_r36168482
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java 
---
    @@ -144,11 +230,22 @@ else if (message instanceof Terminated) {
                                String msg = "Lost connection to JobManager " + 
jobManager.path();
                                logger.info(msg);
                                submitter.tell(decorateMessage(new 
Status.Failure(new Exception(msg))), getSelf());
    +                           scheduler.cancel();
    +                           resetContextAndActor();
                        } else {
                                logger.error("Received 'Terminated' for unknown 
actor " + target);
                        }
                }
     
    +           // ============= No messgaes received in the job manager 
timeout duration ========
    +           else if (message instanceof ReceiveTimeout){
    --- End diff --
    
    According to the JavaDocs of `setReceiveTimeout`, it might happen that you 
receive a `ReceiveTimeout` message even though you've just received another 
message. You should guard against this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to