zentol commented on a change in pull request #6477: [FLINK-10027] Add logging 
to StreamingFileSink
URL: https://github.com/apache/flink/pull/6477#discussion_r207222719
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java
 ##########
 @@ -230,6 +256,11 @@ void onSuccessfulCompletionOfCheckpoint(long 
checkpointId) throws IOException {
 
        void rollOnProcessingTimeIfNeeded(long timestamp) throws IOException {
                if (inProgressPart != null && 
rollingPolicy.shouldRollOnProcessingTime(inProgressPart, timestamp)) {
+                       if (LOG.isDebugEnabled()) {
+                               LOG.debug("Subtask {} closing in-progress part 
file for bucket id={} due to timeout " +
+                                               "(in-progress file created @ 
{}, last updated @ {} and now is {}).",
+                                               subtaskIndex, bucketId, 
inProgressPart.getCreationTime(), inProgressPart.getLastUpdateTime(), 
timestamp);
 
 Review comment:
   "and current time is"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to