zentol commented on a change in pull request #6477: [FLINK-10027] Add logging
to StreamingFileSink
URL: https://github.com/apache/flink/pull/6477#discussion_r207223752
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -153,6 +168,10 @@ private void initializeActiveBuckets(final
ListState<byte[]> bucketStates) throw
private void handleRestoredBucketState(final BucketState<BucketID>
recoveredState) throws Exception {
final BucketID bucketId = recoveredState.getBucketId();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Restoring: {}", recoveredState);
Review comment:
I would generally try to have each logging statement by self-contained, i.e.
this one should also contain the subtask index for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
