zentol commented on a change in pull request #6477: [FLINK-10027] Add logging
to StreamingFileSink
URL: https://github.com/apache/flink/pull/6477#discussion_r207216446
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/BucketAssigner.java
##########
@@ -28,49 +28,45 @@
import java.io.Serializable;
/**
- * A bucketer is used with a {@link
org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink}
- * to determine the {@link
org.apache.flink.streaming.api.functions.sink.filesystem.Bucket} each incoming
element
+ * A bucketer is used with a {@link StreamingFileSink} to determine the {@link
Bucket} each incoming element
* should be put into.
*
* <p>The {@code StreamingFileSink} can be writing to many buckets at a time,
and it is responsible for managing
* a set of active buckets. Whenever a new element arrives it will ask the
{@code Bucketer} for the bucket the
* element should fall in. The {@code Bucketer} can, for example, determine
buckets based on system time.
*
* @param <IN> The type of input elements.
- * @param <BucketID> The type of the object returned by the {@link
#getBucketId(Object, Bucketer.Context)}. This has to have
+ * @param <BucketID> The type of the object returned by the {@link
#getBucketId(Object, BucketAssigner.Context)}. This has to have
* a correct {@link #hashCode()} and {@link #equals(Object)}
method. In addition, the {@link Path}
* to the created bucket will be the result of the {@link
#toString()} of this method, appended to
- * the {@code basePath} specified in the
- * {@link
org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink
StreamingFileSink}
+ * the {@code basePath} specified in the {@link
StreamingFileSink StreamingFileSink}.
*/
@PublicEvolving
-public interface Bucketer<IN, BucketID> extends Serializable {
+public interface BucketAssigner<IN, BucketID> extends Serializable {
/**
* Returns the identifier of the bucket the provided element should be
put into.
* @param element The current element being processed.
- * @param context The {@link SinkFunction.Context context} used by the
- * {@link
org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink
sink}.
+ * @param context The {@link SinkFunction.Context context} used by the
{@link StreamingFileSink sink}.
*
* @return A string representing the identifier of the bucket the
element should be put into.
* This actual path to the bucket will result from the concatenation of
the returned string
Review comment:
"The actual path"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
