Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/967#discussion_r36280020
--- Diff:
flink-core/src/main/java/org/apache/flink/ps/impl/ParameterServerIgniteImpl.java
---
@@ -0,0 +1,105 @@
+/*
+ * Copyright 2015 EURA NOVA.
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ps.impl;
+
+import org.apache.flink.ps.model.ParameterElement;
+import org.apache.flink.ps.model.ParameterServer;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.Ignition;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * An implementation of {@link org.apache.flink.ps.model.ParameterServer}
using Apache Ignite
+ */
+public class ParameterServerIgniteImpl implements ParameterServer {
+
+ private static final Logger log =
LoggerFactory.getLogger(ParameterServerIgniteImpl.class);
+
+ public final static String CACHE_NAME =
ParameterServerIgniteImpl.class.getSimpleName();
+
+ public final static String GRID_NAME = "FLINK_PARAMETER_SERVER";
+
+ public static CacheConfiguration<String, ParameterElement>
getParameterCacheConfiguration() {
+ CacheConfiguration<String, ParameterElement> parameterCacheCfg
= new CacheConfiguration<String, ParameterElement>();
+ parameterCacheCfg.setCacheMode(CacheMode.PARTITIONED);
+ parameterCacheCfg.setName(CACHE_NAME + "_parameter");
+// parameterCacheCfg.setAtomicityMode(CacheAtomicityMode.ATOMIC);
+ return parameterCacheCfg;
+ }
+
+ public static CacheConfiguration<String, ParameterElement>
getSharedCacheConfiguration() {
+ CacheConfiguration<String, ParameterElement> sharedCacheCfg =
new CacheConfiguration<String, ParameterElement>();
+ sharedCacheCfg.setCacheMode(CacheMode.REPLICATED);
+ sharedCacheCfg.setName(CACHE_NAME + "_SHARED");
+ return sharedCacheCfg;
+ }
+
+ private Ignite ignite = null;
+ private IgniteCache<String, ParameterElement> parameterCache = null;
+ private IgniteCache<String, ParameterElement> sharedCache = null;
+
+ public ParameterServerIgniteImpl(String name, boolean client) {
+ try {
+ CacheConfiguration<String, ParameterElement>
parameterCacheCfg = getParameterCacheConfiguration();
+ CacheConfiguration<String, ParameterElement>
sharedCacheCfg =
+ getSharedCacheConfiguration();
+
+ IgniteConfiguration cfg1 = new IgniteConfiguration();
+ cfg1.setGridName(name);
+ cfg1.setPeerClassLoadingEnabled(true);
+ cfg1.setCacheConfiguration(parameterCacheCfg,
sharedCacheCfg);
+
+ // Beware that client mode in Ignite have a whole
different meaning than what it usually means
+ // You still need to hav a grid instantiated to access
the values, though you won't store anything
+ if (client) {
+ cfg1.setClientMode(true);
+ Ignition.setClientMode(true);
+ }
+ if (log.isInfoEnabled()) {
+ String mode = client ? "client" : "server";
+ log.info("Starting parameter server " + name +
" in " + mode + " mode");
+ }
+ this.ignite = Ignition.start(cfg1);
+
+ parameterCache =
ignite.getOrCreateCache(parameterCacheCfg).withAsync();
+ sharedCache =
ignite.getOrCreateCache(sharedCacheCfg).withAsync();
+
+ log.debug("I hereby confirm that parameter cache is
async enabled: " + parameterCache.isAsync());
+ log.debug("I hereby confirm that shared cache is async
enabled: " + sharedCache.isAsync());
+
+ } catch (Exception e) {
+ e.printStackTrace();
--- End diff --
Can you forward the exception as a runtime exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
