[
https://issues.apache.org/jira/browse/FLINK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583983#comment-16583983
]
ASF GitHub Bot commented on FLINK-10142:
----------------------------------------
pnowojski commented on a change in pull request #6555: [FLINK-10142][network]
reduce locking around credit notification
URL: https://github.com/apache/flink/pull/6555#discussion_r210920075
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -170,6 +170,65 @@ public Void call() throws Exception {
}
}
+ @Test
+ public void testConcurrentNotifyBufferAvailableAndRelease() throws
Exception {
Review comment:
Hmmm, isn't this cover by for example
`org.apache.flink.streaming.runtime.io.benchmark.StreamNetworkThroughputBenchmarkTest#largeRemoteMode`?
Maybe we do not need this test after all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Reduce synchronization overhead for credit notifications
> --------------------------------------------------------
>
> Key: FLINK-10142
> URL: https://issues.apache.org/jira/browse/FLINK-10142
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.2, 1.6.0, 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
>
> When credit-based flow control was introduced, we also added some checks and
> optimisations for uncommon code paths that make common code paths
> unnecessarily more expensive, e.g. checking whether a channel was released
> before forwarding a credit notification to Netty. Such checks would have to
> be confirmed by the Netty thread anyway and thus only add additional load for
> something that happens only once (per channel).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
