[
https://issues.apache.org/jira/browse/FLINK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591331#comment-16591331
]
ASF GitHub Bot commented on FLINK-10142:
----------------------------------------
zhijiangW commented on issue #6555: [FLINK-10142][network] reduce locking
around credit notification
URL: https://github.com/apache/flink/pull/6555#issuecomment-415692414
Thanks @NicoK for polishing the related processes.
Actually there are two main changes in this pr:
1. Remove some strict checks to reduce overheads in common cases.
2. Remove notifications outside of the lock part.
I reviewed the above modifications and seemed good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce synchronization overhead for credit notifications
> --------------------------------------------------------
>
> Key: FLINK-10142
> URL: https://issues.apache.org/jira/browse/FLINK-10142
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.2, 1.6.0, 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
>
> When credit-based flow control was introduced, we also added some checks and
> optimisations for uncommon code paths that make common code paths
> unnecessarily more expensive, e.g. checking whether a channel was released
> before forwarding a credit notification to Netty. Such checks would have to
> be confirmed by the Netty thread anyway and thus only add additional load for
> something that happens only once (per channel).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
