[
https://issues.apache.org/jira/browse/FLINK-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588768#comment-16588768
]
ASF GitHub Bot commented on FLINK-10193:
----------------------------------------
GJL opened a new pull request #6601: [FLINK-10193] Add @RpcTimeout to
JobMasterGateway.triggerSavepoint
URL: https://github.com/apache/flink/pull/6601
## What is the purpose of the change
*This adds the `@RpcTimeout` annotation to
`JobMasterGateway.triggerSavepoint` so that the default timeout is overridden.*
cc: @uce @tillrohrmann
## Brief change log
- *Add @RpcTimeout to `JobMasterGateway.triggerSavepoint`.*
## Verifying this change
This change added tests and can be verified as follows:
- *Manually verified the change by running `SlowToCheckpoint` job attached
to FLINK-10193 issue.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Default RPC timeout is used when triggering savepoint via JobMasterGateway
> --------------------------------------------------------------------------
>
> Key: FLINK-10193
> URL: https://issues.apache.org/jira/browse/FLINK-10193
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.3, 1.6.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0, 1.5.4
>
> Attachments: SlowToCheckpoint.java
>
>
> When calling {{JobMasterGateway#triggerSavepoint(String, boolean, Time)}},
> the default timeout is used because the time parameter of the method is not
> annotated with {{@RpcTimeout}}.
> *Expected behavior*
> * timeout for the RPC should be {{RpcUtils.INF_TIMEOUT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
