[
https://issues.apache.org/jira/browse/FLINK-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596159#comment-16596159
]
ASF GitHub Bot commented on FLINK-10193:
----------------------------------------
tillrohrmann commented on issue #6601: [FLINK-10193] Add @RpcTimeout to
JobMasterGateway.triggerSavepoint
URL: https://github.com/apache/flink/pull/6601#issuecomment-416898324
You're right @GJL. Then I would vote for the first test case. Something
along the lines:
```
Future future1 = jm.triggerSavepoint(1 ms);
Future future2 = jm.triggerSavepoint(inf);
future1.get() fails with TimeoutException && !future2.isDone()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Default RPC timeout is used when triggering savepoint via JobMasterGateway
> --------------------------------------------------------------------------
>
> Key: FLINK-10193
> URL: https://issues.apache.org/jira/browse/FLINK-10193
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.3, 1.6.0, 1.7.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0, 1.5.4
>
> Attachments: SlowToCheckpoint.java
>
>
> When calling {{JobMasterGateway#triggerSavepoint(String, boolean, Time)}},
> the default timeout is used because the time parameter of the method is not
> annotated with {{@RpcTimeout}}.
> *Expected behavior*
> * timeout for the RPC should be {{RpcUtils.INF_TIMEOUT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
