GJL commented on a change in pull request #6678: [FLINK-10255] Only react to 
onAddedJobGraph signal when being leader
URL: https://github.com/apache/flink/pull/6678#discussion_r217045367
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
 ##########
 @@ -861,14 +861,18 @@ public void grantLeadership(final UUID 
newLeaderSessionID) {
                        getMainThreadExecutor());
        }
 
-       protected CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
+       CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
 
 Review comment:
   Should be `private`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to