GJL commented on a change in pull request #6678: [FLINK-10255] Only react to
onAddedJobGraph signal when being leader
URL: https://github.com/apache/flink/pull/6678#discussion_r217044938
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher.java
##########
@@ -80,9 +80,16 @@ void completeJobExecution(ArchivedExecutionGraph
archivedExecutionGraph) {
}
@VisibleForTesting
- public CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID
jobId, @Nonnull Time timeout) {
+ CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID jobId,
@Nonnull Time timeout) {
return callAsyncWithoutFencing(
() -> getJobTerminationFuture(jobId),
timeout).thenCompose(Function.identity());
}
+
+ @VisibleForTesting
Review comment:
Not sure about `@VisibleForTesting` here. This class is already a test
utility. It is even in the `test` sources directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
