twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217365862
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -448,48 +448,13 @@ abstract class BatchTableEnvironment(
* @return The optimized [[RelNode]] tree
*/
private[flink] def optimize(relNode: RelNode): RelNode = {
-
- // 0. convert sub-queries before query decorrelation
- val convSubQueryPlan = runHepPlanner(
- HepMatchOrder.BOTTOM_UP, FlinkRuleSets.TABLE_SUBQUERY_RULES, relNode,
relNode.getTraitSet)
-
- // 0. convert table references
- val fullRelNode = runHepPlanner(
- HepMatchOrder.BOTTOM_UP,
- FlinkRuleSets.TABLE_REF_RULES,
- convSubQueryPlan,
- relNode.getTraitSet)
-
- // 1. decorrelate
+ val convSubQueryPlan = optimizeConvertSubQueries(relNode)
Review comment:
This again adds a lot of public methods to the table environments in Java.
Can we move the entire optimize method and sub-methods to a
`TableEnvironmentUtils` class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
