twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r217382202
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala ########## @@ -166,9 +172,14 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder) extends RelShuttle { val right = join.getRight.accept(this) LogicalJoin.create(left, right, join.getCondition, join.getVariablesSet, join.getJoinType) - } + def visit(temporalJoin: LogicalTemporalTableJoin): RelNode = { + val left = temporalJoin.getLeft.accept(this) + val right = temporalJoin.getRight.accept(this) + + temporalJoin.copy(temporalJoin.getTraitSet, List(left, right)) Review comment: I guess we need more logic here. At first I also thought that we don't need special treatment of time attributes here. However, if we have a processing-time temporal join we need to materialize all rowtime attributes of both inputs. So this method needs to look at the time attributes defined by the join condition. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services