[ 
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614727#comment-16614727
 ] 

ASF GitHub Bot commented on FLINK-9713:
---------------------------------------

twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] 
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217638668
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
 ##########
 @@ -139,6 +139,23 @@ case class WindowReference(name: String, tpe: 
Option[TypeInformation[_]] = None)
   override def toString: String = s"'$name"
 }
 
+case class TemporalTableReference(name: String, typeInformation: 
TypeInformation[_])
 
 Review comment:
   Why do we need this class? Window references and table references are 
necessary to call `window.rowtime` (extract the rowtime out of a window) or 
`table.in(1, 2, 3)` but when do we need to references the temporal table?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support versioned joins in planning phase
> -----------------------------------------
>
>                 Key: FLINK-9713
>                 URL: https://issues.apache.org/jira/browse/FLINK-9713
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.5.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT 
>   o.amount * r.rate 
> FROM 
>   Orders AS o, 
>   LATERAL TABLE (Rates(o.rowtime)) AS r 
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to