[
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614730#comment-16614730
]
ASF GitHub Bot commented on FLINK-9713:
---------------------------------------
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217412622
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamTemporalJoinToCoProcessTranslator.scala
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.nodes.datastream
+
+import org.apache.calcite.rel.core.{JoinInfo, JoinRelType}
+import org.apache.calcite.rex._
+import org.apache.flink.api.common.functions.{FlatJoinFunction, MapFunction}
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.streaming.api.functions.co.CoProcessFunction
+import org.apache.flink.table.api.{StreamQueryConfig, TableConfig,
TableException, ValidationException}
+import org.apache.flink.table.calcite.FlinkTypeFactory._
+import org.apache.flink.table.codegen.{FunctionCodeGenerator,
GeneratedFunction}
+import org.apache.flink.table.plan.logical.rel.LogicalTemporalTableJoin._
+import org.apache.flink.table.plan.schema.RowSchema
+import org.apache.flink.table.plan.util.RexDefaultVisitor
+import org.apache.flink.table.runtime.join.TemporalJoin
+import org.apache.flink.table.runtime.types.{CRow, CRowTypeInfo}
+import org.apache.flink.types.Row
+import org.apache.flink.util.Preconditions.checkState
+
+class DataStreamTemporalJoinToCoProcessTranslator(
+ textualRepresentation: String,
+ config: TableConfig,
+ returnType: TypeInformation[Row],
+ leftSchema: RowSchema,
+ rightSchema: RowSchema,
+ joinInfo: JoinInfo,
+ rexBuilder: RexBuilder)
+ extends DataStreamJoinToCoProcessTranslator(
+ config,
+ returnType,
+ leftSchema,
+ rightSchema,
+ joinInfo,
+ rexBuilder) {
+
+ var leftTimeAttribute: Option[RexNode] = None
+
+ var rightTimeAttribute: Option[RexNode] = None
+
+ var rightPrimaryKeyExpression: Option[RexNode] = None
+
+ override val nonEquiJoinPredicates: Option[RexNode] =
extractTemporalJoinCondition()
+
+ def extractTemporalJoinCondition(): Option[RexNode] = {
+ checkState(
+ !joinInfo.isEqui,
+ "Missing %s in join condition",
+ TEMPORAL_JOIN_CONDITION)
+
+ val nonEquiJoinRex: RexNode = joinInfo.getRemaining(rexBuilder)
+ val temporalJoinConditionExtractor = new TemporalJoinConditionExtractor(
+ nonEquiJoinRex.toString)
+
+ Some(temporalJoinConditionExtractor.apply(nonEquiJoinRex))
+ }
+
+ override protected def createCoProcessFunction(
+ joinType: JoinRelType,
+ queryConfig: StreamQueryConfig,
+ joinFunction: GeneratedFunction[FlatJoinFunction[Row, Row, Row], Row])
+ : CoProcessFunction[CRow, CRow, CRow] = {
+
+ checkState(
+ leftTimeAttribute.isDefined &&
+ rightPrimaryKeyExpression.isDefined,
+ "Missing %s in join condition",
+ TEMPORAL_JOIN_CONDITION)
+
+ if (rightTimeAttribute.isDefined) {
+ throw new ValidationException(
+ s"Currently only proctime temporal joins are supported in
[${textualRepresentation}]")
+ }
+
+ joinType match {
+ case JoinRelType.INNER =>
+ new TemporalJoin(
+ leftSchema.typeInfo,
+ rightSchema.typeInfo,
+ joinFunction.name,
+ joinFunction.code,
+ queryConfig)
+ case _ =>
+ throw new ValidationException(
+ s"Only ${JoinRelType.INNER} temporal join is supported in
[${textualRepresentation}]")
+ }
+ }
+
+ private class TemporalJoinConditionExtractor(
+ nonEquiJoinCondition: String)
+ extends RexShuttle {
+
+ override def visitCall(call: RexCall): RexNode = {
+ if (call.getOperator != TEMPORAL_JOIN_CONDITION) {
+ return super.visitCall(call)
+ }
+
+ if (leftTimeAttribute.isDefined
+ || rightPrimaryKeyExpression.isDefined
+ || rightTimeAttribute.isDefined) {
+ throw new ValidationException(
Review comment:
Validation exceptions indicate that the user did something wrong, but here
it would be a bug right? So a `IllegalStateException` might be more appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support versioned joins in planning phase
> -----------------------------------------
>
> Key: FLINK-9713
> URL: https://issues.apache.org/jira/browse/FLINK-9713
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT
> o.amount * r.rate
> FROM
> Orders AS o,
> LATERAL TABLE (Rates(o.rowtime)) AS r
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
