twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219407109
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala ########## @@ -175,13 +173,41 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder) extends RelShuttle { val rewrittenTemporalJoin = temporalJoin.copy(temporalJoin.getTraitSet, List(left, right)) - // Materialize all of the time attributes from the right side of temporal join - val indicesToMaterialize = - (left.getRowType.getFieldCount until rewrittenTemporalJoin.getRowType.getFieldCount).toSet + val indicesToMaterialize = gatherIndicesToMaterialize(rewrittenTemporalJoin, left, right) materializerUtils.projectAndMaterializeFields(rewrittenTemporalJoin, indicesToMaterialize) } + private def gatherIndicesToMaterialize( + temporalJoin: Join, + left: RelNode, + right: RelNode) + : Set[Int] = { + + // Materialize all of the time attributes from the right side of temporal join + var indicesToMaterialize = + (left.getRowType.getFieldCount until temporalJoin.getRowType.getFieldCount).toSet + + if (!hasRowtimeAttribute(right.getRowType)) { Review comment: Did you also add a test for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services