twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] 
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r219407507
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
 ##########
 @@ -191,12 +174,10 @@ case class RowtimeAttribute(expr: Expression) extends 
TimeAttribute(expr) {
         ValidationSuccess
       case WindowReference(_, _) =>
         ValidationFailure("Reference to a rowtime or proctime window 
required.")
-      case TemporalTableReference(_, _) =>
-        ValidationSuccess
       case any =>
         ValidationFailure(
-          s"The '.rowtime' expression can only be used for table definitions, 
windows, " +
-            s" and temporal tables, while [${any}] was found.")
+          s"The '.rowtime' expression can only be used for table definitions, 
windows " +
+            s"and temporal table definitions, while [$any] was found.")
 
 Review comment:
   I think table definitions are not supported anymore. So we can reset this 
message entirely, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to