azagrebin commented on a change in pull request #6734: [FLINK-9455][RM] Add 
support for multi task slot TaskExecutors
URL: https://github.com/apache/flink/pull/6734#discussion_r219969250
 
 

 ##########
 File path: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -191,6 +193,13 @@ public MesosResourceManager(
                this.workersInNew = new HashMap<>(8);
                this.workersInLaunch = new HashMap<>(8);
                this.workersBeingReturned = new HashMap<>(8);
+
+               final ContaineredTaskManagerParameters 
containeredTaskManagerParameters = 
taskManagerParameters.containeredParameters();
 
 Review comment:
   I would create a method to create and return `slotsPerWorker` to unload 
constructor code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to