azagrebin commented on a change in pull request #6734: [FLINK-9455][RM] Add
support for multi task slot TaskExecutors
URL: https://github.com/apache/flink/pull/6734#discussion_r219972864
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -691,20 +703,15 @@ public void taskTerminated(TaskMonitor.TaskTerminated
message) {
/**
* Creates a launchable task for Fenzo to process.
*/
- private LaunchableMesosWorker createLaunchableMesosWorker(Protos.TaskID
taskID, ResourceProfile resourceProfile) {
+ private LaunchableMesosWorker createLaunchableMesosWorker(Protos.TaskID
taskID) {
// create the specific TM parameters from the resource profile
and some defaults
MesosTaskManagerParameters params = new
MesosTaskManagerParameters(
- resourceProfile.getCpuCores() < 1.0 ?
taskManagerParameters.cpus() : resourceProfile.getCpuCores(),
+ taskManagerParameters.cpus(),
Review comment:
This looks like a copying of immutable `MesosTaskManagerParameters`. Is it
on purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
