Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144152
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
config.timeout,
libCache,
fileCache,
- runtimeInfo)
+ new TaskRuntimeInfo(hostname, taskManagerConfig,
tdd.getAttemptNumber))
--- End diff --
generally we try to keep one PR for one issue, exceptions should only be
done for closely related issues.
why did you decide to add these issues into this PR? ( i have a hard time
understanding it, since the commits barely touch the same files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
