Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/970#discussion_r37144275
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -897,7 +897,7 @@ class TaskManager(
             config.timeout,
             libCache,
             fileCache,
    -        runtimeInfo)
    +        new TaskRuntimeInfo(hostname, taskManagerConfig, 
tdd.getAttemptNumber))
    --- End diff --
    
    I would prefer if you opened a second PR once this is merged. The issues 
are not really related to each other; the 2nd commit was simply made based on 
the 1st commit. We would end up having two separate discussions in 1 PR, which 
i think is a bad idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to