zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#issuecomment-431087755
 
 
   I understood what the fallback is supposed to do, but it doesn't make sense 
that something generic like `rest.address` uses the very specific 
`jobmanager.rpc.address` as a fall-back. Falling back to a _more specific_ 
option is conceptually not sound.
   If you want to make the fallback behavior re-usable I'd suggest a dedicated 
`dispatcher.rest.port` option with fall-backs to `rest.port` and 
`jobmanager.rpc.address` which you then use to configure the options that the 
`RestEndpoint` expects.
   This way you retain the convenient fallback behavior without coupling the 
rest configuration to any other component.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to