[
https://issues.apache.org/jira/browse/FLINK-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660704#comment-16660704
]
ASF GitHub Bot commented on FLINK-10637:
----------------------------------------
tillrohrmann commented on issue #6899: [FLINK-10637] Use MiniClusterResource
for tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#issuecomment-432261105
This is a good question @zentol. I guess it would not hurt (apart from
looking a bit ugly in `flink-runtime`) to not change the package name. That
way, people should not be affected by moving this class from one module into
another.
I would actually propose the following: We create a
`org.apache.flink.test.util.MiniClusterResource extends
org.apache.flink.runtime.util.MiniClusterResource` and mark it as deprecated.
The same applies to the `MiniClusterResourceConfiguration`. That we can remove
this class with next major release after our users have hopefully migrated to
the right class. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Start MiniCluster with random REST port
> ---------------------------------------
>
> Key: FLINK-10637
> URL: https://issues.apache.org/jira/browse/FLINK-10637
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4, 1.6.1, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The {{MiniCluster}} picks a random port for the {{RpcService}} but not for
> the REST server endpoint. Due to this it falls back to {{8081}}. This can
> lead to port conflicts if tests are executed concurrently.
> I propose to rename the {{MiniClusterResource}} into
> {{MiniClusterResourceWithRestClient}} and add a new {{MiniClusterResource}}
> which only starts a {{MiniCluster}} with the REST port set to 0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
