[
https://issues.apache.org/jira/browse/FLINK-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660361#comment-16660361
]
ASF GitHub Bot commented on FLINK-10637:
----------------------------------------
tillrohrmann commented on a change in pull request #6899: [FLINK-10637] Use
MiniClusterResource for tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#discussion_r227312621
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
##########
@@ -91,7 +91,7 @@
private TestingServer zkServer;
- public MiniClusterResource miniClusterResource;
Review comment:
You're right. I'll iterate over all the `MiniClusterWithClientResource` and
replace them with `MiniClusterResource` where possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Start MiniCluster with random REST port
> ---------------------------------------
>
> Key: FLINK-10637
> URL: https://issues.apache.org/jira/browse/FLINK-10637
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4, 1.6.1, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The {{MiniCluster}} picks a random port for the {{RpcService}} but not for
> the REST server endpoint. Due to this it falls back to {{8081}}. This can
> lead to port conflicts if tests are executed concurrently.
> I propose to rename the {{MiniClusterResource}} into
> {{MiniClusterResourceWithRestClient}} and add a new {{MiniClusterResource}}
> which only starts a {{MiniCluster}} with the REST port set to 0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
