tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227872252
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
##########
@@ -145,17 +149,61 @@
* <p>If the returned future must not be completed right away (a.k.a.
the slot request
* can be queued), allowQueuedScheduling must be set to true.
*
+ * @deprecated this method will be removed once the handling of slot
sharing is completely extracted from the slot
+ * pool into a dedicated {@link Scheduler} component. The call is then
replaced by calls to
+ * {@link #getAvailableSlotsInformation()}, {@link
#allocateAvailableSlot(SlotRequestId, AllocationID)}, and
+ * {@link #requestNewAllocatedSlot(SlotRequestId, ResourceProfile,
Time)}.
Review comment:
What's preventing us from removing this method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
