tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227877459
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -312,7 +313,7 @@ public void validateRunsInMainThread() {
/**
* Executor which executes runnables in the main thread context.
*/
- protected static class MainThreadExecutor implements Executor {
+ protected static class MainThreadExecutor implements
MainThreadExecutable {
Review comment:
`MainThreadExecutable` was actually intended to be a marker interface for
the `RpcServer`. I would recommend to let the `MainThreadExecutor` implement
the `ScheduledExecutor`. That way, there is no need to change the
`MainThreadExecutable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
