[ 
https://issues.apache.org/jira/browse/FLINK-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665968#comment-16665968
 ] 

ASF GitHub Bot commented on FLINK-10676:
----------------------------------------

hequn8128 opened a new pull request #6949: [FLINK-10676][table] Add 'as' method 
for OverWindowWithOrderBy
URL: https://github.com/apache/flink/pull/6949
 
 
   
   ## What is the purpose of the change
   
   The preceding clause of OVER Window in the traditional database is optional. 
The default is UNBOUNDED. So we can add the `as` method to 
`OverWindowWithOrderBy`. This way OVER Window is written more easily. e.g.:
   `.window(Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as 
'w)`
   Can be simplified as follows:
   `.window(Over partitionBy 'c orderBy 'proctime as 'w)`
   
   SQL has already supported such feature.
   
   ## Brief change log
   
     - Add `as` function for `OverWindowWithOrderBy` both for scala and java.
     - Add tests to check result plan.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added tests that validate result plan, such as tests in `OverWindowTest` 
and `OverWindowStringExpressionTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add 'as' method for OverWindowWithOrderBy in Java API
> -----------------------------------------------------
>
>                 Key: FLINK-10676
>                 URL: https://issues.apache.org/jira/browse/FLINK-10676
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.7.0
>            Reporter: sunjincheng
>            Assignee: Hequn Cheng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The preceding clause of OVER Window in the traditional database is optional. 
> The default is UNBOUNDED. So we can add the "as" method to 
> OverWindowWithOrderBy. This way OVERWindow is written more easily. e.g.:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as 
> 'w){code}
> Can be simplified as follows:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime as 'w){code}
> What do you think?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to