[ 
https://issues.apache.org/jira/browse/FLINK-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678451#comment-16678451
 ] 

ASF GitHub Bot commented on FLINK-10676:
----------------------------------------

hequn8128 commented on issue #6949: [FLINK-10676][table] Add 'as' method for 
OverWindowWithOrderBy
URL: https://github.com/apache/flink/pull/6949#issuecomment-436680634
 
 
   Hi @sunjincheng121 , thanks a lot for your view. I think all of the 
suggestions are good! I have addressed the comments and updated the pr.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add 'as' method for OverWindowWithOrderBy in Java API
> -----------------------------------------------------
>
>                 Key: FLINK-10676
>                 URL: https://issues.apache.org/jira/browse/FLINK-10676
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.7.0
>            Reporter: sunjincheng
>            Assignee: Hequn Cheng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The preceding clause of OVER Window in the traditional database is optional. 
> The default is UNBOUNDED. So we can add the "as" method to 
> OverWindowWithOrderBy. This way OVERWindow is written more easily. e.g.:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as 
> 'w){code}
> Can be simplified as follows:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime as 'w){code}
> What do you think?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to