Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/949#issuecomment-132935282
@ChengXiangLi, you're right, I should have noticed earlier and raise a
flag. But your work is not in vain. I think it's some excellent piece of work
and the `sample` method could also become part of the core API right away.
For the sake of completeness, let's do it once the `sampleWithSize` method
works also robustly. I think your proposition for the next steps is a good way
to continue with it. Once you've moved the `sample` and `sampleWithSize`
methods to the `DataSetUtils` class, we close and merge this PR. In the
meantime, I'll create a JIRA for the topK operator, where we can discuss the
matter further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
