Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/949#issuecomment-133990256
Hi, @sachingoel0101 , while sample with fraction, it's not easy to verify
whether the DataSet is sampled with input fraction. In the test, i take 5 times
sample, use the average size to computer the result fraction, and then compare
the result fraction with input fraction, verify their difference is not more
than 10% percent. The following case may happens as well, Sampler sample the
DataSet with input fraction, but the sampled result size is too small or too
large that beyond our verification condition, it happens, just with very little
possibility, say less than 0.001 in this test. it should be ok if this failure
happens very occasionally, please let me know if you found it's not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
