[
https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675081#comment-16675081
]
ASF GitHub Bot commented on FLINK-10711:
----------------------------------------
twalthr opened a new pull request #7023: [FLINK-10711] [e2e] Allow basic error
handling with bash
URL: https://github.com/apache/flink/pull/7023
## What is the purpose of the change
This commit modifies the test infrastructure to allow bash's basic
error handling mechanism with `set -e`. Many tests are not
ready for a globally defined strict error handling. For now, at
least newly developed tests should consider this flag. If a test
causes an error, a test fails with `"[FAIL] Test script contains errors"`.
## Brief change log
- Make it possible to enable `set -e`
## Verifying this change
Run `./run-single-test.sh ./test-scripts/test_batch_allround.sh` as an
example with the `set` command uncommented.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> flink-end-to-end-tests can fail silently
> ----------------------------------------
>
> Key: FLINK-10711
> URL: https://issues.apache.org/jira/browse/FLINK-10711
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Piotr Nowojski
> Assignee: Timo Walther
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Because they are written in bash and they are not setting
> {code:bash}
> set -e
> {code}
> at the beginning, errors can be swallowed silently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
