[
https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675201#comment-16675201
]
ASF GitHub Bot commented on FLINK-10711:
----------------------------------------
twalthr commented on a change in pull request #7023: [FLINK-10711] [e2e] Allow
basic error handling with bash
URL: https://github.com/apache/flink/pull/7023#discussion_r230761025
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -320,15 +323,18 @@ function check_logs_for_errors {
| grep -v "java.lang.NoClassDefFoundError:
org/apache/hadoop/yarn/exceptions/YarnException" \
| grep -v "java.lang.NoClassDefFoundError:
org/apache/hadoop/conf/Configuration" \
| grep -v
"org.apache.flink.fs.shaded.hadoop3.org.apache.commons.beanutils.FluentPropertyBeanIntrospector
- Error when creating PropertyDescriptor for public final void
org.apache.flink.fs.shaded.hadoop3.org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)!
Ignoring this property." \
- | grep -ic "error")
+ | grep -ic "error" || true)
Review comment:
Yes, we could do it even more cryptic using `|| :` as discussed here:
https://stackoverflow.com/questions/41078968/why-is-grep-c-with-0-count-exits-program-with-status-code-1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> flink-end-to-end-tests can fail silently
> ----------------------------------------
>
> Key: FLINK-10711
> URL: https://issues.apache.org/jira/browse/FLINK-10711
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Piotr Nowojski
> Assignee: Timo Walther
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Because they are written in bash and they are not setting
> {code:bash}
> set -e
> {code}
> at the beginning, errors can be swallowed silently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
