[
https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675227#comment-16675227
]
ASF GitHub Bot commented on FLINK-10711:
----------------------------------------
pnowojski commented on a change in pull request #7023: [FLINK-10711] [e2e]
Allow basic error handling with bash
URL: https://github.com/apache/flink/pull/7023#discussion_r230767200
##########
File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh
##########
@@ -17,8 +17,6 @@
# limitations under the License.
################################################################################
-set -o pipefail
Review comment:
My comment was not targeted to `elasticsearch-common.sh` alone, but to all
of the scripts. Do we want to assume that `test-scripts/common.sh` is included
before anything else anywhere? I mean we could, but that can be quite fragile
convention.
On the other hand, I don't want to overthink this, since we would like to
start replacing those bash scripts after 1.7 release anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> flink-end-to-end-tests can fail silently
> ----------------------------------------
>
> Key: FLINK-10711
> URL: https://issues.apache.org/jira/browse/FLINK-10711
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Piotr Nowojski
> Assignee: Timo Walther
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Because they are written in bash and they are not setting
> {code:bash}
> set -e
> {code}
> at the beginning, errors can be swallowed silently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
