[
https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681556#comment-16681556
]
ASF GitHub Bot commented on FLINK-7155:
---------------------------------------
zentol commented on a change in pull request #6976: [FLINK-7155][metrics] Add
new metrics reporter to InfluxDB
URL: https://github.com/apache/flink/pull/6976#discussion_r232280371
##########
File path:
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/MetricMapper.java
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.metrics.influxdb;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.HistogramStatistics;
+import org.apache.flink.metrics.Meter;
+
+import org.influxdb.dto.Point;
+
+import java.time.Instant;
+import java.util.concurrent.TimeUnit;
+
+class MetricMapper {
+
+ static Point map(MeasurementInfo info, Instant timestamp, Gauge<?>
gauge) {
+ Point.Builder builder = builder(info, timestamp);
+ Object value = gauge.getValue();
+ if (value instanceof Number) {
+ builder.addField("value", (Number) value);
+ } else {
+ builder.addField("value", String.valueOf(value));
+ }
+ return builder.build();
+ }
+
+ static Point map(MeasurementInfo info, Instant timestamp, Counter
counter) {
+ return builder(info, timestamp)
+ .addField("count", counter.getCount())
+ .build();
+ }
+
+ static Point map(MeasurementInfo info, Instant timestamp, Histogram
histogram) {
+ HistogramStatistics statistics = histogram.getStatistics();
+ return builder(info, timestamp)
+ .addField("run-count", histogram.getCount())
Review comment:
unless this naming scheme is endorsed/encouraged by influx-db themselves I'd
like to make Flink reporters more consistent so it's easier for users to
migrate from one reporter to another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Influxdb metrics reporter
> -----------------------------
>
> Key: FLINK-7155
> URL: https://issues.apache.org/jira/browse/FLINK-7155
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: Patrick Lucas
> Assignee: Patrick Lucas
> Priority: Major
> Labels: pull-request-available
>
> [~jgrier] has a [simple Influxdb metrics reporter for
> Flink|https://github.com/jgrier/flink-stuff/tree/master/flink-influx-reporter]
> that is a thing wrapper around [a lightweight, public-domain Influxdb
> reporter|https://github.com/davidB/metrics-influxdb] for Codahale metrics.
> We can implement this very easily in Java in the same as as
> flink-metrics-graphite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
