[
https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688042#comment-16688042
]
ASF GitHub Bot commented on FLINK-7155:
---------------------------------------
zentol commented on a change in pull request #6976: [FLINK-7155][metrics] Add
new metrics reporter to InfluxDB
URL: https://github.com/apache/flink/pull/6976#discussion_r233838430
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/MetricMapperTest.java
##########
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.metrics.influxdb;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.HistogramStatistics;
+import org.apache.flink.metrics.Meter;
+
+import org.influxdb.dto.Point;
+import org.junit.Test;
+
+import java.time.Instant;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test for {@link MetricMapper} checking that metrics are converted to
InfluxDB client objects as expected.
+ */
+public class MetricMapperTest {
+
+ private final String name = "a-metric-name";
+ private final MeasurementInfo info = getMeasurementInfo(name);
+ private final Instant timestamp = Instant.now();
+
+ @Test
+ public void testMapGauge() {
+ verifyPoint(
+ MetricMapper.map(info, timestamp, (Gauge<Number>) () ->
42),
+ "value=42");
+
+ verifyPoint(
+ MetricMapper.map(info, timestamp, (Gauge<Number>) () ->
null),
+ "value=null");
+
+ verifyPoint(
+ MetricMapper.map(info, timestamp, (Gauge<String>) () ->
"hello"),
+ "value=hello");
+
+ verifyPoint(
+ MetricMapper.map(info, timestamp, (Gauge<Long>) () ->
42L),
+ "value=42");
+ }
+
+ @Test
+ public void testMapCounter() {
+ Counter counter = mock(Counter.class);
+ when(counter.getCount()).thenReturn(42L);
+
+ verifyPoint(
+ MetricMapper.map(info, timestamp, counter),
+ "count=42");
+ }
+
+ @Test
+ public void testMapHistogram() {
+ HistogramStatistics statistics =
mock(HistogramStatistics.class);
Review comment:
> Only methods required for a test are mocked.
So if I change the reporter implementation to access any other method it
will now suddenly fail with an NPE since the method was never implemented.
Which actually never happens at runtime.
Test should be independent of the implementation and continue to work if
things change; otherwise they provide little value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Influxdb metrics reporter
> -----------------------------
>
> Key: FLINK-7155
> URL: https://issues.apache.org/jira/browse/FLINK-7155
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: Patrick Lucas
> Assignee: Patrick Lucas
> Priority: Major
> Labels: pull-request-available
>
> [~jgrier] has a [simple Influxdb metrics reporter for
> Flink|https://github.com/jgrier/flink-stuff/tree/master/flink-influx-reporter]
> that is a thing wrapper around [a lightweight, public-domain Influxdb
> reporter|https://github.com/davidB/metrics-influxdb] for Codahale metrics.
> We can implement this very easily in Java in the same as as
> flink-metrics-graphite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
