[
https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701477#comment-16701477
]
ASF GitHub Bot commented on FLINK-10820:
----------------------------------------
zhijiangW commented on issue #7051: [FLINK-10820][network] Simplify the
RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051#issuecomment-442345552
@pnowojski , thanks for above suggestions.
I would submit the fixup commit for addressing previous comments and another
hotfix commit for renaming separately.
BTW, I am always not sure this kind of hotfix commit should be included in
this pr or another separate pr. If another pr, should I create a corresponding
jira ticket? Which way is better in your opinion? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Simplify the RebalancePartitioner implementation
> ------------------------------------------------
>
> Key: FLINK-10820
> URL: https://issues.apache.org/jira/browse/FLINK-10820
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> _The current {{RebalancePartitioner}} implementation seems a little hacky for
> selecting a random number as the first channel index, and the following
> selections based on this random index in round-robin fashion._
> _Especially for the corner case of {{numChannels = Integer.MAX_VALUE}}, it
> would trigger next random index once reaching the last channel index.
> Actually the random index should be selected only once at the first time._
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
