[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701565#comment-16701565 ]
ASF GitHub Bot commented on FLINK-10820: ---------------------------------------- zhijiangW commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442372490 Yeah, thanks for above specific explanations which all make sense in my opinion. I just want to confirm whether there are other implicit rules in community. :) I already submitted the hotfix commit for addressing previous comments, then i would submit another pr for rename issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify the RebalancePartitioner implementation > ------------------------------------------------ > > Key: FLINK-10820 > URL: https://issues.apache.org/jira/browse/FLINK-10820 > Project: Flink > Issue Type: Sub-task > Components: Network > Affects Versions: 1.8.0 > Reporter: zhijiang > Assignee: zhijiang > Priority: Minor > Labels: pull-request-available > > _The current {{RebalancePartitioner}} implementation seems a little hacky for > selecting a random number as the first channel index, and the following > selections based on this random index in round-robin fashion._ > _Especially for the corner case of {{numChannels = Integer.MAX_VALUE}}, it > would trigger next random index once reaching the last channel index. > Actually the random index should be selected only once at the first time._ -- This message was sent by Atlassian JIRA (v7.6.3#76005)