[
https://issues.apache.org/jira/browse/FLINK-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707944#comment-16707944
]
ASF GitHub Bot commented on FLINK-10543:
----------------------------------------
sunjincheng121 commented on a change in pull request #6918:
[FLINK-10543][table] Leverage efficient timer deletion in relational operators
URL: https://github.com/apache/flink/pull/6918#discussion_r238471156
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala
##########
@@ -1067,32 +1058,36 @@ class JoinHarnessTest extends HarnessTestBase {
CRow(1: JInt, "Hi1")))
testHarness.processElement2(new StreamRecord(
CRow(false, 1: JInt, "Hi1")))
- assertEquals(5, testHarness.numKeyedStateEntries())
- assertEquals(3, testHarness.numProcessingTimeTimers())
+ // lkeys(1, 2) rkeys() timer_key_time(1:5, 2:6)
+ assertEquals(4, testHarness.numKeyedStateEntries())
+ assertEquals(2, testHarness.numProcessingTimeTimers())
testHarness.setProcessingTime(4)
testHarness.processElement2(new StreamRecord(
CRow(2: JInt, "Hello1")))
- assertEquals(7, testHarness.numKeyedStateEntries())
- assertEquals(4, testHarness.numProcessingTimeTimers())
+ // lkeys(1, 2) rkeys(2) timer_key_time(1:5, 2:6)
+ assertEquals(5, testHarness.numKeyedStateEntries())
+ assertEquals(2, testHarness.numProcessingTimeTimers())
testHarness.processElement1(new StreamRecord(
CRow(false, 1: JInt, "aaa")))
- // expired left stream record with key value of 1
+ // expired stream records with key value of 1
testHarness.setProcessingTime(5)
testHarness.processElement2(new StreamRecord(
CRow(1: JInt, "Hi2")))
testHarness.processElement2(new StreamRecord(
CRow(false, 1: JInt, "Hi2")))
- assertEquals(5, testHarness.numKeyedStateEntries())
- assertEquals(3, testHarness.numProcessingTimeTimers())
+ // lkeys(2) rkeys(2) timer_key_time(1:9, 2:6)
+ assertEquals(4, testHarness.numKeyedStateEntries())
+ assertEquals(2, testHarness.numProcessingTimeTimers())
- // expired all left stream record
+ // expired stream records with key value of 2
testHarness.setProcessingTime(6)
- assertEquals(3, testHarness.numKeyedStateEntries())
- assertEquals(2, testHarness.numProcessingTimeTimers())
+ // lkeys() rkeys() timer_key_time(1:9)
+ assertEquals(1, testHarness.numKeyedStateEntries())
+ assertEquals(1, testHarness.numProcessingTimeTimers())
- // expired right stream record with key value of 2
- testHarness.setProcessingTime(8)
+ // expired all date
Review comment:
`all date` -> `all data` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Leverage efficient timer deletion in relational operators
> ---------------------------------------------------------
>
> Key: FLINK-10543
> URL: https://issues.apache.org/jira/browse/FLINK-10543
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Hequn Cheng
> Priority: Minor
> Labels: pull-request-available
>
> FLINK-9423 added support for efficient timer deletions. This feature is
> available since Flink 1.6 and should be used by the relational operator of
> SQL and Table API.
> Currently, we use a few workarounds to handle situations when deleting timers
> would be the better solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
