[ 
https://issues.apache.org/jira/browse/FLINK-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714716#comment-16714716
 ] 

Aljoscha Krettek commented on FLINK-11090:
------------------------------------------

We could also remove it, since it's {{PublicEvolving}} and not {{Public}}. 
Plus, this method is not really used by users directly, it's more of an 
internal method to be called by the Scala API.

> Unused parameter in WindowedStream.aggregate()
> ----------------------------------------------
>
>                 Key: FLINK-11090
>                 URL: https://issues.apache.org/jira/browse/FLINK-11090
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>
> The {{aggregateResultType}} parameter in {{WindowedStream.aggregate()}} seems 
> useless. Or what have I missed?
> If it is useless, I prefer to remove the parameter by adding a new API and 
> deprecate the current one. We can't remove it directly as it is 
> PublicEvolving.
> {code:java}
>       @PublicEvolving
>       public <ACC, V, R> SingleOutputStreamOperator<R> aggregate(
>                       AggregateFunction<T, ACC, V> aggregateFunction,
>                       ProcessWindowFunction<V, R, K, W> windowFunction,
>                       TypeInformation<ACC> accumulatorType,
>                       TypeInformation<V> aggregateResultType,
>                       TypeInformation<R> resultType) {
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to